qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/5] util/uri: Remove the uri_string_escape() function


From: Thomas Huth
Subject: Re: [PATCH 3/5] util/uri: Remove the uri_string_escape() function
Date: Tue, 23 Jan 2024 07:03:03 +0100
User-agent: Mozilla Thunderbird

On 22/01/2024 21.59, Stefan Weil wrote:
Am 22.01.24 um 20:17 schrieb Thomas Huth:

It is not used in QEMU - and if somebody needs this functionality,
they can simply use g_uri_escape_string() from the glib instead.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
  include/qemu/uri.h |  1 -
  util/uri.c         | 64 ----------------------------------------------
  2 files changed, 65 deletions(-)


The removed function is used in util/uri.c, so this patch breaks the compilation.

That can be fixed by applying patch 4 before this one.

With that re-ordering you may add my signature:

Reviewed-by: Stefan Weil <sw@weilnetz.de>

D'oh, I originally developed the patches the other way round indeed, but then thought it would be nicer for review this way and swapped the order without checking :-( ... I'll swap it back again.

Thanks!

 Thomas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]