[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL v2 6/8] linux-user/elfload: test return value of getrlimit
|
From: |
Richard Henderson |
|
Subject: |
[PULL v2 6/8] linux-user/elfload: test return value of getrlimit |
|
Date: |
Tue, 23 Jan 2024 20:24:10 +1000 |
From: Thomas Weißschuh <thomas@t-8ch.de>
Should getrlimit() fail the value of dumpsize.rlimit_cur may not be
initialized. Avoid reading garbage data by checking the return value of
getrlimit.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Thomas Weißschuh <thomas@t-8ch.de>
Message-Id: <20240120-qemu-user-dumpable-v3-1-6aa410c933f1@t-8ch.de>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
linux-user/elfload.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index cf9e74468b..c596871938 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -4667,9 +4667,9 @@ static int elf_core_dump(int signr, const CPUArchState
*env)
init_note_info(&info);
errno = 0;
- getrlimit(RLIMIT_CORE, &dumpsize);
- if (dumpsize.rlim_cur == 0)
+ if (getrlimit(RLIMIT_CORE, &dumpsize) == 0 && dumpsize.rlim_cur == 0) {
return 0;
+ }
corefile = core_dump_filename(ts);
--
2.34.1
- [PULL v2 0/8] tcg pach queue, Richard Henderson, 2024/01/23
- [PULL v2 1/8] tcg: Remove unreachable code, Richard Henderson, 2024/01/23
- [PULL v2 2/8] tcg: Make the cleanup-on-error path unique, Richard Henderson, 2024/01/23
- [PULL v2 3/8] linux-user: Fixed cpu restore with pc 0 on SIGBUS, Richard Henderson, 2024/01/23
- [PULL v2 4/8] tcg/s390x: Fix encoding of VRIc, VRSa, VRSc insns, Richard Henderson, 2024/01/23
- [PULL v2 5/8] linux-user/riscv: Adjust vdso signal frame cfa offsets, Richard Henderson, 2024/01/23
- [PULL v2 7/8] linux-user/elfload: check PR_GET_DUMPABLE before creating coredump, Richard Henderson, 2024/01/23
- [PULL v2 6/8] linux-user/elfload: test return value of getrlimit,
Richard Henderson <=
- [PULL v2 8/8] tcg/arm: Fix SIGILL in tcg_out_qemu_st_direct, Richard Henderson, 2024/01/23
- Re: [PULL v2 0/8] tcg pach queue, Peter Maydell, 2024/01/25