|
| From: | Thomas Huth |
| Subject: | Re: [PATCH v3 00/16] tests: enable meson test timeouts to improve debuggability |
| Date: | Tue, 23 Jan 2024 18:47:50 +0100 |
| User-agent: | Mozilla Thunderbird |
On 23/01/2024 17.50, Michael Tokarev wrote:
15.12.2023 10:03, Thomas Huth wrote:This is a respin of Daniel's series that re-enables the meson test runner timeouts. To make sure that we do not get into trouble on older systems, I ran all the tests with "make check SPEED=slow -j32" on my laptop that has only 16 SMT threads, so each test was running quite a bit slower than with a normal "-j$(nproc)" run. I think that these timeouts should now work in most cases - if not, we still can adjust them easily later.I'm picking this up for stable branches too, since there we have the same problems in CI environment. In particular, bios-tables-test almost always times out, even hitting retry doesn't help. Let's see how it goes..
Uh, wait, that does not make too much sense ... if bios-tables-test already times out *without* the additional meson-based timeouts, then adding the meson timeouts won't help. bios-tables-test uses the manually coded timeout from boot_sector_test() that is currently set to 600 seconds. If you hit that timeout, that likely means that something is really broken in your branch - or is it sometimes still succeeding?
Thomas
| [Prev in Thread] | Current Thread | [Next in Thread] |