[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] migration: Plug memory leak on HMP migrate error path
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH] migration: Plug memory leak on HMP migrate error path |
|
Date: |
Wed, 24 Jan 2024 07:47:26 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Peter Xu <peterx@redhat.com> writes:
> On Tue, Jan 23, 2024 at 04:33:43PM +0000, Peter Maydell wrote:
>> On Wed, 17 Jan 2024 at 19:49, Markus Armbruster <armbru@redhat.com> wrote:
>> >
>> > hmp_migrate() leaks @caps when qmp_migrate() fails. Plug the leak
>> > with g_autoptr().
>> >
>> > Fixes: 967f2de5c9ec (migration: Implement MigrateChannelList to hmp
>> > migration flow.) v8.2.0-rc0
>> > Fixes: CID 1533124
>>
>> Isn't this 1533125 ? 1533124 is a false positive in
>> the migrate_mode() function.
Yes.
> Indeed.. I fixed it in the staging branch (which will be in the final
> pull), thanks.
>
> https://gitlab.com/peterx/qemu/-/commit/74278c11b980429916116baf0f742357af51ebb4
Thanks for catching & fixing my typo!