Re: [PATCH] hw/i386/pc_piix: Make piix_intx_routing_notifier_xen() more device independent

[Philippe Mathieu-Daudé]

On 14/1/24 13:25, Michael S. Tsirkin wrote:
> On Sun, Jan 14, 2024 at 12:21:59PM +0000, Bernhard Beschow wrote:
> > Am 7. Januar 2024 23:16:23 UTC schrieb Bernhard Beschow <shentey@gmail.com>:
> > > This is a follow-up on commit 89965db43cce "hw/isa/piix3: Avoid Xen-specific
> > > variant of piix3_write_config()" which introduced
> > > piix_intx_routing_notifier_xen(). This function is implemented in board code but
> > > accesses the PCI configuration space of the PIIX ISA function to determine the
> > > PCI interrupt routes. Avoid this by reusing pci_device_route_intx_to_irq() which
> > > makes piix_intx_routing_notifier_xen() more device-agnostic.
> > >
> > > One remaining improvement would be making piix_intx_routing_notifier_xen()
> > > agnostic towards the number of PCI interrupt routes and move it to xen-hvm.
> > > This might be useful for possible Q35 Xen efforts but remains a future exercise
> > > for now.
> > >
> > > Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> >
> > Hi Michael,
> >
> > could you tag this, too? Or do we need another R-b?
> >
> > Best regards,
> > Bernhard
>
> tagged, too.

FYI merged as commit ebd92d6de3.