[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 56/66] i386/tdx: Disable SMM for TDX VMs
|
From: |
Xiaoyao Li |
|
Subject: |
[PATCH v4 56/66] i386/tdx: Disable SMM for TDX VMs |
|
Date: |
Wed, 24 Jan 2024 22:23:18 -0500 |
TDX doesn't support SMM and VMM cannot emulate SMM for TDX VMs because
VMM cannot manipulate TDX VM's memory.
Disable SMM for TDX VMs and error out if user requests to enable SMM.
Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
---
target/i386/kvm/tdx.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/target/i386/kvm/tdx.c b/target/i386/kvm/tdx.c
index 4fbb18135951..7eb3628763ae 100644
--- a/target/i386/kvm/tdx.c
+++ b/target/i386/kvm/tdx.c
@@ -695,11 +695,19 @@ static Notifier tdx_machine_done_notify = {
int tdx_kvm_init(MachineState *ms, Error **errp)
{
+ X86MachineState *x86ms = X86_MACHINE(ms);
TdxGuest *tdx = TDX_GUEST(OBJECT(ms->cgs));
int r = 0;
ms->require_guest_memfd = true;
+ if (x86ms->smm == ON_OFF_AUTO_AUTO) {
+ x86ms->smm = ON_OFF_AUTO_OFF;
+ } else if (x86ms->smm == ON_OFF_AUTO_ON) {
+ error_setg(errp, "TDX VM doesn't support SMM");
+ return -EINVAL;
+ }
+
if (!tdx_caps) {
r = get_tdx_capabilities(errp);
if (r) {
--
2.34.1
- [PATCH v4 47/66] i386/tdx: Call KVM_TDX_INIT_VCPU to initialize TDX vcpu, (continued)
- [PATCH v4 47/66] i386/tdx: Call KVM_TDX_INIT_VCPU to initialize TDX vcpu, Xiaoyao Li, 2024/01/24
- [PATCH v4 46/66] i386/tdx: register TDVF as private memory, Xiaoyao Li, 2024/01/24
- [PATCH v4 52/66] i386/tdx: Handle TDG.VP.VMCALL<REPORT_FATAL_ERROR>, Xiaoyao Li, 2024/01/24
- [PATCH v4 51/66] i386/tdx: handle TDG.VP.VMCALL<MapGPA> hypercall, Xiaoyao Li, 2024/01/24
- [PATCH v4 50/66] i386/tdx: handle TDG.VP.VMCALL<GetQuote>, Xiaoyao Li, 2024/01/24
- [PATCH v4 54/66] pci-host/q35: Move PAM initialization above SMRAM initialization, Xiaoyao Li, 2024/01/24
- [PATCH v4 55/66] q35: Introduce smm_ranges property for q35-pci-host, Xiaoyao Li, 2024/01/24
- [PATCH v4 53/66] i386/tdx: Wire TDX_REPORT_FATAL_ERROR with GuestPanic facility, Xiaoyao Li, 2024/01/24
- [PATCH v4 57/66] i386/tdx: Disable PIC for TDX VMs, Xiaoyao Li, 2024/01/24
- [PATCH v4 58/66] i386/tdx: Don't allow system reset for TDX VMs, Xiaoyao Li, 2024/01/24
- [PATCH v4 56/66] i386/tdx: Disable SMM for TDX VMs,
Xiaoyao Li <=
- [PATCH v4 59/66] i386/tdx: LMCE is not supported for TDX, Xiaoyao Li, 2024/01/24
- [PATCH v4 60/66] hw/i386: add eoi_intercept_unsupported member to X86MachineState, Xiaoyao Li, 2024/01/24
- [PATCH v4 61/66] hw/i386: add option to forcibly report edge trigger in acpi tables, Xiaoyao Li, 2024/01/24
- [PATCH v4 62/66] i386/tdx: Don't synchronize guest tsc for TDs, Xiaoyao Li, 2024/01/24
- [PATCH v4 63/66] i386/tdx: Only configure MSR_IA32_UCODE_REV in kvm_init_msrs() for TDs, Xiaoyao Li, 2024/01/24
- [PATCH v4 64/66] i386/tdx: Skip kvm_put_apicbase() for TDs, Xiaoyao Li, 2024/01/24
- [PATCH v4 65/66] i386/tdx: Don't get/put guest state for TDX VMs, Xiaoyao Li, 2024/01/24
- [PATCH v4 66/66] docs: Add TDX documentation, Xiaoyao Li, 2024/01/24