[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 22/36] hw/misc/xlnx-versal-crl: Include generic 'cpu-qom.h' instea
|
From: |
Peter Maydell |
|
Subject: |
[PULL 22/36] hw/misc/xlnx-versal-crl: Include generic 'cpu-qom.h' instead of 'cpu.h' |
|
Date: |
Fri, 26 Jan 2024 14:33:27 +0000 |
From: Philippe Mathieu-Daudé <philmd@linaro.org>
"target/arm/cpu.h" is target specific, any file including it
becomes target specific too, thus this is the same for any file
including "hw/misc/xlnx-versal-crl.h".
"hw/misc/xlnx-versal-crl.h" doesn't require any target specific
definition however, only the target-agnostic QOM definitions
from "target/arm/cpu-qom.h". Include the latter header to avoid
tainting unnecessary objects as target-specific.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20240118200643.29037-14-philmd@linaro.org
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
include/hw/misc/xlnx-versal-crl.h | 2 +-
hw/misc/xlnx-versal-crl.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/hw/misc/xlnx-versal-crl.h
b/include/hw/misc/xlnx-versal-crl.h
index dfb8dff197d..dba6d3585d1 100644
--- a/include/hw/misc/xlnx-versal-crl.h
+++ b/include/hw/misc/xlnx-versal-crl.h
@@ -11,7 +11,7 @@
#include "hw/sysbus.h"
#include "hw/register.h"
-#include "target/arm/cpu.h"
+#include "target/arm/cpu-qom.h"
#define TYPE_XLNX_VERSAL_CRL "xlnx-versal-crl"
OBJECT_DECLARE_SIMPLE_TYPE(XlnxVersalCRL, XLNX_VERSAL_CRL)
diff --git a/hw/misc/xlnx-versal-crl.c b/hw/misc/xlnx-versal-crl.c
index 1f1762ef163..1a596f1cf57 100644
--- a/hw/misc/xlnx-versal-crl.c
+++ b/hw/misc/xlnx-versal-crl.c
@@ -18,6 +18,7 @@
#include "hw/register.h"
#include "hw/resettable.h"
+#include "target/arm/cpu.h"
#include "target/arm/arm-powerctl.h"
#include "target/arm/multiprocessing.h"
#include "hw/misc/xlnx-versal-crl.h"
--
2.34.1
- [PULL 12/36] hw/arm/smmuv3: Include missing 'hw/registerfields.h' header, (continued)
- [PULL 12/36] hw/arm/smmuv3: Include missing 'hw/registerfields.h' header, Peter Maydell, 2024/01/26
- [PULL 08/36] hw/arm: Add AHCI/SATA controller to Allwinner R40 and Bananapi board, Peter Maydell, 2024/01/26
- [PULL 20/36] target/arm: Declare ARM_CPU_TYPE_NAME/SUFFIX in 'cpu-qom.h', Peter Maydell, 2024/01/26
- [PULL 14/36] target/arm/cpu-features: Include missing 'hw/registerfields.h' header, Peter Maydell, 2024/01/26
- [PULL 16/36] target/arm/cpregs: Include missing 'kvm-consts.h' header, Peter Maydell, 2024/01/26
- [PULL 17/36] target/arm: Rename arm_cpu_mp_affinity, Peter Maydell, 2024/01/26
- [PULL 18/36] target/arm: Create arm_cpu_mp_affinity, Peter Maydell, 2024/01/26
- [PULL 19/36] target/arm: Expose arm_cpu_mp_affinity() in 'multiprocessing.h' header, Peter Maydell, 2024/01/26
- [PULL 21/36] hw/cpu/a9mpcore: Build it only once, Peter Maydell, 2024/01/26
- [PULL 23/36] hw/misc/xlnx-versal-crl: Build it only once, Peter Maydell, 2024/01/26
- [PULL 22/36] hw/misc/xlnx-versal-crl: Include generic 'cpu-qom.h' instead of 'cpu.h',
Peter Maydell <=
- [PULL 25/36] hw/arm/armv7m: Make 'hw/intc/armv7m_nvic.h' a target agnostic header, Peter Maydell, 2024/01/26
- [PULL 30/36] fsl-imx6ul: Add various missing unimplemented devices, Peter Maydell, 2024/01/26
- [PULL 24/36] target/arm: Expose M-profile register bank index definitions, Peter Maydell, 2024/01/26
- [PULL 27/36] target/arm: Move e2h_access() helper around, Peter Maydell, 2024/01/26
- [PULL 26/36] target/arm: Move ARM_CPU_IRQ/FIQ definitions to 'cpu-qom.h' header, Peter Maydell, 2024/01/26
- [PULL 28/36] target/arm: Move GTimer definitions to new 'gtimer.h' header, Peter Maydell, 2024/01/26
- [PULL 29/36] hw/arm: Build various units only once, Peter Maydell, 2024/01/26
- [PULL 32/36] hw/char/imx_serial: Implement receive FIFO and ageing timer, Peter Maydell, 2024/01/26
- [PULL 36/36] hw/arm: add PCIe to Freescale i.MX6, Peter Maydell, 2024/01/26
- [PULL 31/36] docs/system/arm/virt.rst: Add note on CPU features off by default, Peter Maydell, 2024/01/26