[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 5/5] migration/multifd: Move zero copy flag into multifd_socket_s
|
From: |
Fabiano Rosas |
|
Subject: |
[PATCH 5/5] migration/multifd: Move zero copy flag into multifd_socket_setup |
|
Date: |
Fri, 26 Jan 2024 19:19:43 -0300 |
The generic multifd save setup code should not be responsible for
deciding how the client code is going to send the data. Since the zero
copy feature is supported only by the socket migration, move the
setting of the flag into the socket specific function.
Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
migration/multifd.c | 7 +------
migration/socket.c | 4 ++++
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/migration/multifd.c b/migration/multifd.c
index 358a4dbf8f..16d02a4aac 100644
--- a/migration/multifd.c
+++ b/migration/multifd.c
@@ -817,12 +817,7 @@ int multifd_save_setup(Error **errp)
p->normal = g_new0(ram_addr_t, page_count);
p->page_size = qemu_target_page_size();
p->page_count = page_count;
-
- if (migrate_zero_copy_send()) {
- p->write_flags = QIO_CHANNEL_WRITE_FLAG_ZERO_COPY;
- } else {
- p->write_flags = 0;
- }
+ p->write_flags = 0;
multifd_new_send_channel_create(p);
}
diff --git a/migration/socket.c b/migration/socket.c
index af22ff7cc4..e9d0a5235c 100644
--- a/migration/socket.c
+++ b/migration/socket.c
@@ -206,6 +206,10 @@ void socket_start_incoming_migration(SocketAddress *saddr,
static int multifd_socket_send_setup(MultiFDSendParams *p, Error **errp)
{
+ if (migrate_zero_copy_send()) {
+ p->write_flags |= QIO_CHANNEL_WRITE_FLAG_ZERO_COPY;
+ }
+
return 0;
}
--
2.35.3
- [PATCH 3/5] migration/multifd: Add multifd_ops->send, (continued)
- [PATCH 3/5] migration/multifd: Add multifd_ops->send, Fabiano Rosas, 2024/01/26
- [PATCH 1/5] migration/multifd: Separate compression ops from non-compression, Fabiano Rosas, 2024/01/26
- Re: [PATCH 1/5] migration/multifd: Separate compression ops from non-compression, Peter Xu, 2024/01/29
- Re: [PATCH 1/5] migration/multifd: Separate compression ops from non-compression, Fabiano Rosas, 2024/01/29
- Re: [PATCH 1/5] migration/multifd: Separate compression ops from non-compression, Peter Xu, 2024/01/30
- Re: [PATCH 1/5] migration/multifd: Separate compression ops from non-compression, Fabiano Rosas, 2024/01/30
- Re: [PATCH 1/5] migration/multifd: Separate compression ops from non-compression, Peter Xu, 2024/01/31
- Re: [PATCH 1/5] migration/multifd: Separate compression ops from non-compression, Fabiano Rosas, 2024/01/31
[PATCH 4/5] migration/multifd: Simplify zero copy send, Fabiano Rosas, 2024/01/26
[PATCH 2/5] migration/multifd: Move multifd_socket_ops to socket.c, Fabiano Rosas, 2024/01/26
[PATCH 5/5] migration/multifd: Move zero copy flag into multifd_socket_setup,
Fabiano Rosas <=
RE: [PATCH 0/5] migration/multifd: Prerequisite cleanups for ongoing work, Liu, Yuan1, 2024/01/28