[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 05/14] analyze-migration.py: Remove trick on parsing ramblocks
|
From: |
peterx |
|
Subject: |
[PULL 05/14] analyze-migration.py: Remove trick on parsing ramblocks |
|
Date: |
Mon, 29 Jan 2024 11:03:56 +0800 |
From: Peter Xu <peterx@redhat.com>
RAM_SAVE_FLAG_MEM_SIZE contains the total length of ramblock idstr to know
whether scanning of ramblocks is complete. Drop the trick.
Reviewed-by: Fabiano Rosas <farosas@suse.de>
Link: 20240117075848.139045-4-peterx@redhat.com">https://lore.kernel.org/r/20240117075848.139045-4-peterx@redhat.com
Signed-off-by: Peter Xu <peterx@redhat.com>
---
scripts/analyze-migration.py | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/scripts/analyze-migration.py b/scripts/analyze-migration.py
index a39dfb8766..8a254a5b6a 100755
--- a/scripts/analyze-migration.py
+++ b/scripts/analyze-migration.py
@@ -151,17 +151,12 @@ def read(self):
addr &= ~(self.TARGET_PAGE_SIZE - 1)
if flags & self.RAM_SAVE_FLAG_MEM_SIZE:
- while True:
+ total_length = addr
+ while total_length > 0:
namelen = self.file.read8()
- # We assume that no RAM chunk is big enough to ever
- # hit the first byte of the address, so when we see
- # a zero here we know it has to be an address, not the
- # length of the next block.
- if namelen == 0:
- self.file.file.seek(-1, 1)
- break
self.name = self.file.readstr(len = namelen)
len = self.file.read64()
+ total_length -= len
self.sizeinfo[self.name] = '0x%016x' % len
if self.write_memory:
print(self.name)
--
2.43.0
- [PULL 00/14] Migration 20240126 patches, peterx, 2024/01/28
- [PULL 01/14] userfaultfd: use 1ULL to build ioctl masks, peterx, 2024/01/28
- [PULL 02/14] migration: Plug memory leak on HMP migrate error path, peterx, 2024/01/28
- [PULL 03/14] migration: Make threshold_size an uint64_t, peterx, 2024/01/28
- [PULL 05/14] analyze-migration.py: Remove trick on parsing ramblocks,
peterx <=
- [PULL 04/14] migration: Drop unnecessary check in ram's pending_exact(), peterx, 2024/01/28
- [PULL 06/14] ci: Add a migration compatibility test job, peterx, 2024/01/28
- [PULL 07/14] ci: Disable migration compatibility tests for aarch64, peterx, 2024/01/28
- [PULL 08/14] migration/yank: Use channel features, peterx, 2024/01/28
- [PULL 09/14] migration: Fix use-after-free of migration state object, peterx, 2024/01/28
- [PULL 10/14] migration: Take reference to migration state around bg_migration_vm_start_bh, peterx, 2024/01/28
- [PULL 11/14] migration: Reference migration state around loadvm_postcopy_handle_run_bh, peterx, 2024/01/28
- [PULL 12/14] migration: Add a wrapper to qemu_bh_schedule, peterx, 2024/01/28
- [PULL 13/14] migration: Centralize BH creation and dispatch, peterx, 2024/01/28
- [PULL 14/14] Make 'uri' optional for migrate QAPI, peterx, 2024/01/28