[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 08/14] migration/yank: Use channel features
|
From: |
peterx |
|
Subject: |
[PULL 08/14] migration/yank: Use channel features |
|
Date: |
Mon, 29 Jan 2024 11:03:59 +0800 |
From: Fabiano Rosas <farosas@suse.de>
Stop using outside knowledge about the io channels when registering
yank functions. Query for features instead.
The yank method for all channels used with migration code currently is
to call the qio_channel_shutdown() function, so query for
QIO_CHANNEL_FEATURE_SHUTDOWN. We could add a separate feature in the
future for indicating whether a channel supports yanking, but that
seems overkill at the moment.
Signed-off-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Peter Xu <peterx@redhat.com>
Link: https://lore.kernel.org/r/20230911171320.24372-9-farosas@suse.de
Signed-off-by: Peter Xu <peterx@redhat.com>
---
migration/yank_functions.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/migration/yank_functions.c b/migration/yank_functions.c
index d5a710a3f2..979e60c762 100644
--- a/migration/yank_functions.c
+++ b/migration/yank_functions.c
@@ -8,12 +8,9 @@
*/
#include "qemu/osdep.h"
-#include "qapi/error.h"
#include "io/channel.h"
#include "yank_functions.h"
#include "qemu/yank.h"
-#include "io/channel-socket.h"
-#include "io/channel-tls.h"
#include "qemu-file.h"
void migration_yank_iochannel(void *opaque)
@@ -26,8 +23,7 @@ void migration_yank_iochannel(void *opaque)
/* Return whether yank is supported on this ioc */
static bool migration_ioc_yank_supported(QIOChannel *ioc)
{
- return object_dynamic_cast(OBJECT(ioc), TYPE_QIO_CHANNEL_SOCKET) ||
- object_dynamic_cast(OBJECT(ioc), TYPE_QIO_CHANNEL_TLS);
+ return qio_channel_has_feature(ioc, QIO_CHANNEL_FEATURE_SHUTDOWN);
}
void migration_ioc_register_yank(QIOChannel *ioc)
--
2.43.0
- [PULL 00/14] Migration 20240126 patches, peterx, 2024/01/28
- [PULL 01/14] userfaultfd: use 1ULL to build ioctl masks, peterx, 2024/01/28
- [PULL 02/14] migration: Plug memory leak on HMP migrate error path, peterx, 2024/01/28
- [PULL 03/14] migration: Make threshold_size an uint64_t, peterx, 2024/01/28
- [PULL 05/14] analyze-migration.py: Remove trick on parsing ramblocks, peterx, 2024/01/28
- [PULL 04/14] migration: Drop unnecessary check in ram's pending_exact(), peterx, 2024/01/28
- [PULL 06/14] ci: Add a migration compatibility test job, peterx, 2024/01/28
- [PULL 07/14] ci: Disable migration compatibility tests for aarch64, peterx, 2024/01/28
- [PULL 08/14] migration/yank: Use channel features,
peterx <=
- [PULL 09/14] migration: Fix use-after-free of migration state object, peterx, 2024/01/28
- [PULL 10/14] migration: Take reference to migration state around bg_migration_vm_start_bh, peterx, 2024/01/28
- [PULL 11/14] migration: Reference migration state around loadvm_postcopy_handle_run_bh, peterx, 2024/01/28
- [PULL 12/14] migration: Add a wrapper to qemu_bh_schedule, peterx, 2024/01/28
- [PULL 13/14] migration: Centralize BH creation and dispatch, peterx, 2024/01/28
- [PULL 14/14] Make 'uri' optional for migrate QAPI, peterx, 2024/01/28
- Re: [PULL 00/14] Migration 20240126 patches, Peter Maydell, 2024/01/29