[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] isa-superio: validate floppy.count value
|
From: |
Paolo Bonzini |
|
Subject: |
[PATCH] isa-superio: validate floppy.count value |
|
Date: |
Mon, 29 Jan 2024 14:32:49 +0100 |
Ensure that the value is valid; it can only be zero or one.
And never create a floppy disk controller if it is zero.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/isa/isa-superio.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/isa/isa-superio.c b/hw/isa/isa-superio.c
index 80e0c34652e..34df335598c 100644
--- a/hw/isa/isa-superio.c
+++ b/hw/isa/isa-superio.c
@@ -116,7 +116,9 @@ static void isa_superio_realize(DeviceState *dev, Error
**errp)
}
/* Floppy disc */
- if (!k->floppy.is_enabled || k->floppy.is_enabled(sio, 0)) {
+ assert(k->floppy.count <= 1);
+ if (k->floppy.count &&
+ (!k->floppy.is_enabled || k->floppy.is_enabled(sio, 0))) {
isa = isa_new(TYPE_ISA_FDC);
d = DEVICE(isa);
if (k->floppy.get_iobase) {
--
2.43.0
- [PATCH] isa-superio: validate floppy.count value,
Paolo Bonzini <=