Re: [PATCH v3 15/33] linux-user: Remove qemu_host_page_size from main

[Ilya Leoshkevich]

On Tue, Jan 02, 2024 at 12:57:50PM +1100, Richard Henderson wrote:
> Use qemu_real_host_page_size() instead.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  linux-user/main.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/linux-user/main.c b/linux-user/main.c
> index 0cdaf30d34..5f217cc2a8 100644
> --- a/linux-user/main.c
> +++ b/linux-user/main.c

[...]

> @@ -806,8 +806,10 @@ int main(int argc, char **argv, char **envp)
>       */
>      max_reserved_va = MAX_RESERVED_VA(cpu);
>      if (reserved_va != 0) {
> -        if ((reserved_va + 1) % qemu_host_page_size) {
> -            char *s = size_to_str(qemu_host_page_size);
> +        int host_page_size = qemu_real_host_page_size();
> +
> +        if ((reserved_va + 1) % host_page_size) {
> +            char *s = size_to_str(host_page_size);

Does it make sense to allow values not divisible by TARGET_PAGE_SIZE
here? It's probably not a big deal, since in the worst case we'll
only waste a few bytes, so:

Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>

[...]