Re: [PATCH v3 20/33] linux-user: Do early mmap placement only for reserved_va

[Ilya Leoshkevich]

On Tue, Jan 02, 2024 at 12:57:55PM +1100, Richard Henderson wrote:
> For reserved_va, place all non-fixed maps then proceed
> as for MAP_FIXED.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  linux-user/mmap.c | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/linux-user/mmap.c b/linux-user/mmap.c
> index cc983bedbd..42eb3eb2b4 100644
> --- a/linux-user/mmap.c
> +++ b/linux-user/mmap.c
> @@ -540,17 +540,19 @@ static abi_long target_mmap__locked(abi_ulong start, 
> abi_ulong len,
>      host_offset = offset & -host_page_size;
>  
>      /*
> -     * If the user is asking for the kernel to find a location, do that
> -     * before we truncate the length for mapping files below.
> +     * For reserved_va, we are in full control of the allocation.
> +     * Find a suitible hole and convert to MAP_FIXED.

suitable?

[...]

Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>