[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] pflash: fix sectors vs bytes confusion in blk_pread_nonzeroe
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [PATCH] pflash: fix sectors vs bytes confusion in blk_pread_nonzeroes() |
|
Date: |
Tue, 30 Jan 2024 16:18:13 -0500 |
On Mon, Jan 29, 2024 at 07:27:12PM -0500, Stefan Hajnoczi wrote:
> The following expression is incorrect because blk_pread_nonzeroes()
> deals in units of bytes, not sectors:
>
> bytes = MIN(size - offset, BDRV_REQUEST_MAX_SECTORS)
> ^^^^^^^
>
> BDRV_REQUEST_MAX_BYTES is the appropriate constant.
>
> Fixes: a4b15a8b9ef2 ("pflash: Only read non-zero parts of backend image")
> Cc: Xiang Zheng <zhengxiang9@huawei.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> hw/block/block.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, applied to my block tree:
https://gitlab.com/stefanha/qemu/commits/block
Stefan
signature.asc
Description: PGP signature