[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 14/14] migration/multifd: Forbid spurious wakeups
|
From: |
peterx |
|
Subject: |
[PATCH 14/14] migration/multifd: Forbid spurious wakeups |
|
Date: |
Wed, 31 Jan 2024 18:31:11 +0800 |
From: Peter Xu <peterx@redhat.com>
Now multifd's logic is designed to have no spurious wakeup. I still
remember a talk to Juan and he seems to agree we should drop it now, and if
my memory was right it was there because multifd used to hit that when
still debugging.
Let's drop it and see what can explode; as long as it's not reaching
soft-freeze.
Signed-off-by: Peter Xu <peterx@redhat.com>
---
migration/multifd.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/migration/multifd.c b/migration/multifd.c
index 0f22646f95..bd0e3ea1a5 100644
--- a/migration/multifd.c
+++ b/migration/multifd.c
@@ -766,9 +766,6 @@ static void *multifd_send_thread(void *opaque)
p->pending_sync = false;
qemu_mutex_unlock(&p->mutex);
qemu_sem_post(&p->sem_sync);
- } else {
- qemu_mutex_unlock(&p->mutex);
- /* sometimes there are spurious wakeups */
}
}
--
2.43.0
- [PATCH 10/14] migration/multifd: Move total_normal_pages accounting, (continued)
- [PATCH 10/14] migration/multifd: Move total_normal_pages accounting, peterx, 2024/01/31
- [PATCH 11/14] migration/multifd: Move trace_multifd_send|recv(), peterx, 2024/01/31
- [PATCH 09/14] migration/multifd: Rename p->num_packets and clean it up, peterx, 2024/01/31
- [PATCH 12/14] migration/multifd: multifd_send_prepare_header(), peterx, 2024/01/31
- [PATCH 13/14] migration/multifd: Move header prepare/fill into send_prepare(), peterx, 2024/01/31
- [PATCH 14/14] migration/multifd: Forbid spurious wakeups,
peterx <=
- Re: [PATCH 00/14] migration/multifd: Refactor ->send_prepare() and cleanups, Fabiano Rosas, 2024/01/31