Re: [PATCH v4 3/7] crypto: Modify the qcrypto_block_create to support creation flags

[Daniel P . Berrangé]

On Tue, Jan 30, 2024 at 01:37:21PM +0800, yong.huang@smartx.com wrote:
> From: Hyman Huang <yong.huang@smartx.com>
> 
> Expand the signature of qcrypto_block_create to enable the
> formation of LUKS volumes with detachable headers. To accomplish
> that, introduce QCryptoBlockCreateFlags to instruct the creation
> process to set the payload_offset_sector to 0.
> 
> Signed-off-by: Hyman Huang <yong.huang@smartx.com>
> ---
>  block/crypto.c                 |  1 +
>  block/qcow.c                   |  2 +-
>  block/qcow2.c                  |  2 +-
>  crypto/block-luks.c            | 28 +++++++++++++++++++++-------
>  crypto/block.c                 |  4 +++-
>  crypto/blockpriv.h             |  2 ++
>  include/crypto/block.h         | 11 +++++++++++
>  tests/unit/test-crypto-block.c |  2 ++
>  8 files changed, 42 insertions(+), 10 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|