[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] scripts/checkpatch: Avoid author email mangled by qemu-t
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH 1/2] scripts/checkpatch: Avoid author email mangled by qemu-trivial@ |
|
Date: |
Tue, 2 Apr 2024 12:52:25 +0100 |
On Tue, 2 Apr 2024 at 12:30, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> Commit f5177798d8 ("scripts: report on author emails
> that are mangled by the mailing list") added a check
> for qemu-devel@ list, complete with qemu-trivial@.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 7026895074..4fe4cfd631 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1573,7 +1573,7 @@ sub process {
> $is_patch = 1;
> }
>
> - if ($line =~ /^(Author|From): .* via
> .*<qemu-devel\@nongnu.org>/) {
> + if ($line =~ /^(Author|From): .* via
> .*<qemu-(devel|trivial)\@nongnu\.org>/) {
I recommend checking against qemu-.* rather than trying
to capture explicitly all the suffixes we have. (For instance
there's a line in mailmap for a commit that was attributed
to qemu-block@, which this change still wouldn't catch.)
thanks
-- PMM