Re: [PATCH v12 03/23] target/arm: Add support for FEAT_NMI, Non-maskable Interrupt

[Peter Maydell]

On Wed, 3 Apr 2024 at 11:18, Jinjie Ruan <ruanjinjie@huawei.com> wrote:
>
> Add support for FEAT_NMI. NMI (FEAT_NMI) is an mandatory feature in
> ARMv8.8-A and ARM v9.3-A.
>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> v3:
> - Add Reviewed-by.
> - Adjust to before the MSR patches.
> ---
>  target/arm/internals.h | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/target/arm/internals.h b/target/arm/internals.h
> index dd3da211a3..516e0584bf 100644
> --- a/target/arm/internals.h
> +++ b/target/arm/internals.h
> @@ -1229,6 +1229,9 @@ static inline uint32_t aarch64_pstate_valid_mask(const 
> ARMISARegisters *id)
>      if (isar_feature_aa64_mte(id)) {
>          valid |= PSTATE_TCO;
>      }
> +    if (isar_feature_aa64_nmi(id)) {
> +        valid |= PSTATE_ALLINT;
> +    }

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM