Re: [PATCH-for-9.1 3/7] monitor: Rework stubs to simplify user emulation linking

[Philippe Mathieu-Daudé]

On 8/4/24 11:50, Paolo Bonzini wrote:
> On Thu, Apr 4, 2024 at 9:48 PM Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
> > Currently monitor stubs are scattered in 3 files.
> >
> > Merge these stubs in 2 files, a generic one (monitor-core)
> > included in all builds (in particular user emulation), and
> > a less generic one to be included by tools and system emulation.
> >
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > ---
> >   stubs/fdset.c        | 17 -----------------
>
> Oops, merging fdset.c breaks storage-daemon linking.

Odd. My 'tools_only' build directory is configured with:

'--enable-tools' '--disable-docs' '--disable-system' '--disable-user'

I was building qemu-img & co. I just checked it isn't anymore,
the directory only contains libqemuutil.a, libqom.fa,
libevent-loop-base.fa and tests/unit (I'm on macOS host).

This explained why I missed the link failure. I'll dig to
see when these tools disappeared on macOS.

Regards,

Phil.