Re: [PATCH v2 16/18] stubs: split record/replay stubs further

[Richard Henderson]

On 4/8/24 05:53, Paolo Bonzini wrote:
> replay.c symbols are only needed by user mode emulation, with the
> exception of replay_mode that is needed by both user mode emulation
> (by way of qemu_guest_getrandom) and block layer tools (by way of
> util/qemu-timer.c).
>
> Since it is needed by libqemuutil rather than specific files that
> are part of the tools and emulators, split the replay_mode stub
> into its own file.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   stubs/replay-mode.c | 4 ++++
>   stubs/replay.c      | 2 --
>   stubs/meson.build   | 1 +
>   3 files changed, 5 insertions(+), 2 deletions(-)
>   create mode 100644 stubs/replay-mode.c

I don't see how this helps.

With qemu_guest_getrandom you still pull in replay_read_random and replay_save_random. 
With timerlist_run_timers you still pull in replay_checkpoint.

So both stubs files are still used in the same cases.


r~