Re: [PATCH 1/2] Fix typo to allow migrate_qmp_fail command with 'channels' argument

[Peter Xu]

Het, 

It's all fine, no worries! This is good enough.  Let's finish the discussion in the next patch before a repost. 

Thanks,

On Mon, Apr 8, 2024, 2:35 p.m. Het Gala <het.gala@nutanix.com> wrote:

On 08/04/24 9:05 pm, Peter Xu wrote:

!-------------------------------------------------------------------|
  CAUTION: External Email

|-------------------------------------------------------------------!

Hey, Het,

On Sun, Apr 07, 2024 at 01:21:24PM +0000, Het Gala wrote:

Fixes: (tests/qtest/migration: Add negative tests to validate migration QAPIs)

I think I get your intention to provide two fixup patches on top of
migration-next, which indeed would be preferred so that I can squash them
into the patches before the pull.

However please next time use "git commit --fixup" so that a better subject
will be generated, and that'll make my life (and Fabiano's I suppose in the
future) easier because git rebase understand those subjects.  Then you
don't need Fixes with an empty commit ID.  They'll start with "fixup: XXX"
pointing to a commit with subject rather than commit IDs.

I apologize for any inconvenience caused by not using "git commit --fixup" in my previous submission. Let me resend the patchset with correct message convention. Will take care of this in future patches too, thanks for bringing it to my notice. Regards, Het Gala