Re: [QEMU][PATCH v3 0/7] Xen: support grant mappings.

[Edgar E. Iglesias]

On Wed, Feb 28, 2024 at 8:00 PM Vikram Garhwal <vikram.garhwal@amd.com> wrote:

Hi Manos,
On Wed, Feb 28, 2024 at 03:27:12PM +0200, Manos Pitsidianakis wrote:
> Hello Vikram,
>
> Series doesn't apply on master. Can you rebase and also provide a
> base-commit with --base=<COMMIT_SHA> when you use git-format-patch? This
> will help git rebase if there are any conflicts found locally.
I rebased it with latest master and it works fine. Series is based on following
commit: bfe8020c814a30479a4241aaa78b63960655962b.

For v4, I will send a version with base-commit id.

Can you please share what is base-commit id on your side?

Thanks!
>
> Thanks,

Hi all,

I'll send a v4 on behalf of Vikram.

Stefano, I saw your comments here: https://marc.info/?l=qemu-devel&m=169999555103080

I've manage to loose the email so I can't reply but you indicated that you're OK with the current patch but perhaps would have preferred another approach.

I like what Juergen did (so I RB tagged it) but if you feel strongly about finding another approach we can have a look.

Best regards,

Edgar