[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] Revert "migration: modify test_multifd_tcp_none() to use
|
From: |
Fabiano Rosas |
|
Subject: |
Re: [PATCH 1/4] Revert "migration: modify test_multifd_tcp_none() to use new QAPI syntax" |
|
Date: |
Wed, 10 Apr 2024 10:04:33 -0300 |
Het Gala <het.gala@nutanix.com> writes:
> This reverts commit 8e3766eefbb4036cbc280c1f1a0d28537929f7fb
>
> After addition of 'channels' as the starting argument of new QAPI
> syntax inside postcopy test, even if the user entered the old QAPI
> syntax, test used the new syntax.
> It was a temporary patch added to have some presence of the new syntax
> since the migration qtest framework lacked any logic for introducing
> 'channels' argument.
That wasn't clear to me when we merged that. Was that really the case?
>
> Now that the qtest framework has logic to introduce uri and channel
> argument separately, we can remove this temporary change.
>
> Signed-off-by: Het Gala <het.gala@nutanix.com>
Anyway, I can see the point of this.
Reviewed-by: Fabiano Rosas <farosas@suse.de>
- [PATCH 0/4] tests/qtest/migration: Add postcopy qtests for introducing 'channels' argument with new QAPI syntax, Het Gala, 2024/04/10
- [PATCH 3/4] tests/qtest/migration: Add channels parameter in migrate_incoming_qmp, Het Gala, 2024/04/10
- [PATCH 2/4] tests/qtest/migration: Replace 'migrate-incoming' qtest_qmp_assert_success with migrate_incoming_qmp, Het Gala, 2024/04/10
- [PATCH 4/4] tests/qtest/migration: Add postcopy migration qtests to use 'channels' argument instead of uri, Het Gala, 2024/04/10
- [PATCH 1/4] Revert "migration: modify test_multifd_tcp_none() to use new QAPI syntax", Het Gala, 2024/04/10
- Re: [PATCH 1/4] Revert "migration: modify test_multifd_tcp_none() to use new QAPI syntax",
Fabiano Rosas <=
- Re: [PATCH 1/4] Revert "migration: modify test_multifd_tcp_none() to use new QAPI syntax", Peter Xu, 2024/04/10
- Re: [PATCH 1/4] Revert "migration: modify test_multifd_tcp_none() to use new QAPI syntax", Het Gala, 2024/04/11
- Re: [PATCH 1/4] Revert "migration: modify test_multifd_tcp_none() to use new QAPI syntax", Peter Xu, 2024/04/11
- Re: [PATCH 1/4] Revert "migration: modify test_multifd_tcp_none() to use new QAPI syntax", Het Gala, 2024/04/11
- Re: [PATCH 1/4] Revert "migration: modify test_multifd_tcp_none() to use new QAPI syntax", Peter Xu, 2024/04/11
- Re: [PATCH 1/4] Revert "migration: modify test_multifd_tcp_none() to use new QAPI syntax", Fabiano Rosas, 2024/04/11
- Re: [PATCH 1/4] Revert "migration: modify test_multifd_tcp_none() to use new QAPI syntax", Peter Xu, 2024/04/12
- Re: [PATCH 1/4] Revert "migration: modify test_multifd_tcp_none() to use new QAPI syntax", Fabiano Rosas, 2024/04/12
- Re: [PATCH 1/4] Revert "migration: modify test_multifd_tcp_none() to use new QAPI syntax", Peter Xu, 2024/04/12
- Re: [PATCH 1/4] Revert "migration: modify test_multifd_tcp_none() to use new QAPI syntax", Het Gala, 2024/04/11