Re: [PATCH] hw/misc/applesmc: Simplify DeviceReset handler

[Peter Maydell]

On Wed, 10 Apr 2024 at 19:08, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> Have applesmc_find_key() return a const pointer.
> Since the returned buffers are not modified in
> applesmc_io_data_write(), it is pointless to
> delete and re-add the keys in the DeviceReset
> handler. Add them once in DeviceRealize, and
> discard them in the DeviceUnrealize handler.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> As discussed in
> 6fbcf565-f12c-4196-b6c8-559843c7a78c@linaro.org/">https://lore.kernel.org/qemu-devel/6fbcf565-f12c-4196-b6c8-559843c7a78c@linaro.org/

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM