[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 16/27] disas/microblaze: Merge op->name output into each fprin
|
From: |
Richard Henderson |
|
Subject: |
[PATCH v3 16/27] disas/microblaze: Merge op->name output into each fprintf |
|
Date: |
Fri, 12 Apr 2024 00:33:35 -0700 |
In the common case, issue one single fprintf.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
disas/microblaze.c | 80 +++++++++++++++++++++++-----------------------
1 file changed, 40 insertions(+), 40 deletions(-)
diff --git a/disas/microblaze.c b/disas/microblaze.c
index c729c76585..a537ac65dd 100644
--- a/disas/microblaze.c
+++ b/disas/microblaze.c
@@ -830,54 +830,52 @@ print_insn_microblaze(bfd_vma memaddr, struct
disassemble_info *info)
return 4;
}
- fprintf_func (stream, "%s", op->name);
-
switch (op->inst_type) {
case INST_TYPE_RD_R1_R2:
- fprintf_func(stream, "\t%s, %s, %s",
- get_field_rd(inst), get_field_r1(inst),
+ fprintf_func(stream, "%s\t%s, %s, %s",
+ op->name, get_field_rd(inst), get_field_r1(inst),
get_field_r2(inst));
break;
case INST_TYPE_RD_R1_IMM:
- fprintf_func(stream, "\t%s, %s, %s",
- get_field_rd(inst), get_field_r1(inst),
+ fprintf_func(stream, "%s\t%s, %s, %s",
+ op->name, get_field_rd(inst), get_field_r1(inst),
get_field_imm(inst));
if (get_int_field_r1(inst) == 0) {
print_immval_addr(info, immfound, immval, inst, 0);
}
break;
case INST_TYPE_RD_R1_IMM5:
- fprintf_func(stream, "\t%s, %s, %s",
- get_field_rd(inst), get_field_r1(inst),
+ fprintf_func(stream, "%s\t%s, %s, %s",
+ op->name, get_field_rd(inst), get_field_r1(inst),
get_field_imm5(inst));
break;
case INST_TYPE_RD_RFSL:
- fprintf_func(stream, "\t%s, %s",
- get_field_rd(inst), get_field_rfsl(inst));
+ fprintf_func(stream, "%s\t%s, %s",
+ op->name, get_field_rd(inst), get_field_rfsl(inst));
break;
case INST_TYPE_R1_RFSL:
- fprintf_func(stream, "\t%s, %s",
- get_field_r1(inst), get_field_rfsl(inst));
+ fprintf_func(stream, "%s\t%s, %s",
+ op->name, get_field_r1(inst), get_field_rfsl(inst));
break;
case INST_TYPE_RD_SPECIAL:
- fprintf_func(stream, "\t%s, %s",
- get_field_rd(inst), get_field_special(inst, op));
+ fprintf_func(stream, "%s\t%s, %s",
+ op->name, get_field_rd(inst), get_field_special(inst,
op));
break;
case INST_TYPE_SPECIAL_R1:
- fprintf_func(stream, "\t%s, %s",
- get_field_special(inst, op), get_field_r1(inst));
+ fprintf_func(stream, "%s\t%s, %s",
+ op->name, get_field_special(inst, op),
get_field_r1(inst));
break;
case INST_TYPE_RD_R1:
- fprintf_func(stream, "\t%s, %s",
- get_field_rd(inst), get_field_r1(inst));
+ fprintf_func(stream, "%s\t%s, %s",
+ op->name, get_field_rd(inst), get_field_r1(inst));
break;
case INST_TYPE_R1_R2:
- fprintf_func(stream, "\t%s, %s",
- get_field_r1(inst), get_field_r2(inst));
+ fprintf_func(stream, "%s\t%s, %s",
+ op->name, get_field_r1(inst), get_field_r2(inst));
break;
case INST_TYPE_R1_IMM:
- fprintf_func(stream, "\t%s, %s",
- get_field_r1(inst), get_field_imm(inst));
+ fprintf_func(stream, "%s\t%s, %s",
+ op->name, get_field_r1(inst), get_field_imm(inst));
/*
* The non-pc relative instructions are returns,
* which shouldn't have a label printed.
@@ -887,14 +885,15 @@ print_insn_microblaze(bfd_vma memaddr, struct
disassemble_info *info)
}
break;
case INST_TYPE_RD_IMM:
- fprintf_func(stream, "\t%s, %s",
- get_field_rd(inst), get_field_imm(inst));
+ fprintf_func(stream, "%s\t%s, %s",
+ op->name, get_field_rd(inst), get_field_imm(inst));
print_immval_addr(info, immfound, immval, inst,
op->inst_offset_type == INST_PC_OFFSET
? memaddr : 0);
break;
case INST_TYPE_IMM:
- fprintf_func(stream, "\t%s", get_field_imm(inst));
+ fprintf_func(stream, "%s\t%s",
+ op->name, get_field_imm(inst));
if (op->instr != imm) {
print_immval_addr(info, immfound, immval, inst,
op->inst_offset_type == INST_PC_OFFSET
@@ -902,37 +901,38 @@ print_insn_microblaze(bfd_vma memaddr, struct
disassemble_info *info)
}
break;
case INST_TYPE_RD_R2:
- fprintf_func(stream, "\t%s, %s",
- get_field_rd(inst), get_field_r2(inst));
+ fprintf_func(stream, "%s\t%s, %s",
+ op->name, get_field_rd(inst), get_field_r2(inst));
break;
case INST_TYPE_R2:
- fprintf_func(stream, "\t%s",
- get_field_r2(inst));
+ fprintf_func(stream, "%s\t%s",
+ op->name, get_field_r2(inst));
break;
case INST_TYPE_R1:
- fprintf_func(stream, "\t%s",
- get_field_r1(inst));
+ fprintf_func(stream, "%s\t%s",
+ op->name, get_field_r1(inst));
break;
case INST_TYPE_RD_R1_SPECIAL:
- fprintf_func(stream, "\t%s, %s",
- get_field_rd(inst), get_field_r2(inst));
+ fprintf_func(stream, "%s\t%s, %s",
+ op->name, get_field_rd(inst), get_field_r2(inst));
break;
case INST_TYPE_RD_IMM15:
- fprintf_func(stream, "\t%s, %s",
- get_field_rd(inst), get_field_imm15(inst));
+ fprintf_func(stream, "%s\t%s, %s",
+ op->name, get_field_rd(inst), get_field_imm15(inst));
break;
/* For tuqula instruction */
case INST_TYPE_RD:
- fprintf_func(stream, "\t%s",
- get_field_rd(inst));
+ fprintf_func(stream, "%s\t%s",
+ op->name, get_field_rd(inst));
break;
case INST_TYPE_RFSL:
- fprintf_func(stream, "\t%s",
- get_field_rfsl(inst));
+ fprintf_func(stream, "%s\t%s",
+ op->name, get_field_rfsl(inst));
break;
default:
/* if the disassembler lags the instruction set */
- fprintf_func(stream, "\tundecoded operands, inst is 0x%04lx", inst);
+ fprintf_func(stream, "%s\tundecoded operands, inst is 0x%04lx",
+ op->name, inst);
break;
}
return 4;
--
2.34.1
- [PATCH v3 07/27] system/qtest: Replace sprintf by qemu_hexdump_line, (continued)
- [PATCH v3 07/27] system/qtest: Replace sprintf by qemu_hexdump_line, Richard Henderson, 2024/04/12
- [PATCH v3 09/27] hw/ide/atapi: Use qemu_hexdump_line to avoid sprintf, Richard Henderson, 2024/04/12
- [PATCH v3 10/27] hw/dma/pl330: Use qemu_hexdump_line to avoid sprintf, Richard Henderson, 2024/04/12
- [PATCH v3 08/27] hw/scsi/scsi-disk: Use qemu_hexdump_line to avoid sprintf, Richard Henderson, 2024/04/12
- [PATCH v3 12/27] disas/m68k: Replace sprintf() by snprintf(), Richard Henderson, 2024/04/12
- [PATCH v3 13/27] disas/microblaze: Replace sprintf() by snprintf(), Richard Henderson, 2024/04/12
- [PATCH v3 15/27] target/microblaze: Re-indent print_insn_microblaze, Richard Henderson, 2024/04/12
- [PATCH v3 14/27] disas/microblaze: Split out print_immval_addr, Richard Henderson, 2024/04/12
- [PATCH v3 16/27] disas/microblaze: Merge op->name output into each fprintf,
Richard Henderson <=
- [PATCH v3 11/27] backends/tpm: Use qemu_hexdump_line to avoid sprintf, Richard Henderson, 2024/04/12
- [PATCH v3 05/27] util/hexdump: Inline g_string_append_printf "%02x", Richard Henderson, 2024/04/12
- [PATCH v3 17/27] disas/microblaze: Print registers directly with PRIreg, Richard Henderson, 2024/04/12
- [PATCH v3 23/27] hw/misc/imx: Replace sprintf() by snprintf(), Richard Henderson, 2024/04/12
- [PATCH v3 18/27] disas/microblaze: Print immediates directly with PRIimm, Richard Henderson, 2024/04/12
- [PATCH v3 26/27] target/arm: Replace sprintf() by snprintf(), Richard Henderson, 2024/04/12
- [PATCH v3 22/27] linux-user/flatload: Replace sprintf() by snprintf(), Richard Henderson, 2024/04/12