[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Makefile: fix use of -j without an argument
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH] Makefile: fix use of -j without an argument |
|
Date: |
Fri, 12 Apr 2024 10:02:54 +0200 |
On Thu, Apr 11, 2024 at 5:46 PM Matheus Tavares Bernardino
<quic_mathbern@quicinc.com> wrote:
> + $(if $(filter -j, $(MAKEFLAGS)) \
> + ,, \
> + $(or \
> + $(filter -l% -j%, $(MAKEFLAGS)), \
> + $(if $(filter --jobserver-auth=%, $(MAKEFLAGS)),, -j1)) \
> + ) -d keepdepfile
This is more easily written as $(filter-out -j, $(or ...)).
I've sent a v2.
Paolo
> ninja-cmd-goals = $(or $(MAKECMDGOALS), all)
> ninja-cmd-goals += $(foreach g, $(MAKECMDGOALS), $(.ninja-goals.$g))
>
> --
> 2.37.2
>