Re: [PATCH] target/sparc: Use GET_ASI_CODE for ASI_KERNELTXT and ASI_USERTXT

[M Bazz]

Hi Philippe,

On Fri, Apr 12, 2024 at 7:14 AM Philippe Mathieu-Daudé
<philmd@linaro.org> wrote:
>
> Hi Bazz,
>
> On 12/4/24 06:18, M Bazz wrote:
> > On Thu, Apr 11, 2024, 10:15 PM Richard Henderson
> > <richard.henderson@linaro.org <mailto:richard.henderson@linaro.org>> wrote:
> >
> >     Reads are done with execute access.  It is not clear whether writes
> >     are legal at all -- for now, leave helper_st_asi unchanged, so that
> >     we continue to raise an mmu fault.
> >
> >     This generalizes the exiting code for ASI_KERNELTXT to be usable for
> >     ASI_USERTXT as well, by passing down the MemOpIdx to use.
> >
> >     Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2281
> >     <https://gitlab.com/qemu-project/qemu/-/issues/2281>
> >     Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2059
> >     <https://gitlab.com/qemu-project/qemu/-/issues/2059>
> >     Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1609
> >     <https://gitlab.com/qemu-project/qemu/-/issues/1609>
> >     Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1166
> >     <https://gitlab.com/qemu-project/qemu/-/issues/1166>
> >     Signed-off-by: Richard Henderson <richard.henderson@linaro.org
> >     <mailto:richard.henderson@linaro.org>>
> >     ---
> >       target/sparc/helper.h      |  3 ++
> >       target/sparc/ldst_helper.c | 65 ++++++++++++++++++++++++++------------
> >       target/sparc/translate.c   | 49 ++++++++++++++++++++++++++--
> >       3 files changed, 95 insertions(+), 22 deletions(-)
>
> > Hi Richard,
> >
> > I see this is in your hands now. I agree with your take on leaving
> > writes alone. I'm also grateful for the opportunity to collaborate with you.
> >
> > It brings a smile for the community members who will be touched by this
> > amazing contribution. I see them happily realizing that this perplexing
> > bug has been solved, and in our case finally able to use the debuggers
> > we love! :D
>
> Does that mean you tested this patch and it resolves your issues?
>
> If so, could you add your 'Tested-by: M Bazz <bazz@bazz1.com>' tag
> when committing this patch?
>
> Regards,
>
> Phil.

Yes, I can confirm the issue is resolved. Richard has already made the
pull request. I am appreciative of the fast movement on this.

I would like to have my "Tested-by" tag added to the PR, if it's no
trouble. How might I get it there?

Tested-by: M Bazz <bazz@bazz1.com>

>
> > Thanks for the proper fix, qemu sensei!
> >
> > -bazz
> >
>