Re: [PATCH 09/21] semihosting/uaccess: Avoid including 'cpu.h'

[Richard Henderson]

On 4/17/24 11:27, Philippe Mathieu-Daudé wrote:
> "semihosting/uaccess.h" only requires declarations
> from "exec/cpu-defs.h". Avoid including the huge "cpu.h".
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Message-Id: <20231211212003.21686-6-philmd@linaro.org>
> ---
>   include/semihosting/uaccess.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/semihosting/uaccess.h b/include/semihosting/uaccess.h
> index 3963eafc3e..6c8835fbcb 100644
> --- a/include/semihosting/uaccess.h
> +++ b/include/semihosting/uaccess.h
> @@ -14,7 +14,7 @@
>   #error Cannot include semihosting/uaccess.h from user emulation
>   #endif
>   
> -#include "cpu.h"
> +#include "exec/cpu-defs.h"
>   
>   #define get_user_u64(val, addr)                                         \
>       ({ uint64_t val_ = 0;                                               \


Does this actually need anything besides exec/tswap.h?


r~