Re: [PATCH 18/21] exec: Declare target_words_bigendian() in 'exec/tswap.h'

[Richard Henderson]

On 4/17/24 11:28, Philippe Mathieu-Daudé wrote:
> We usually check target endianess before swapping values,
> so target_words_bigendian() declaration makes sense in
> "exec/tswap.h" with the target swapping helpers.
>
> Remove "hw/core/cpu.h" when it was only included to get
> the target_words_bigendian() declaration.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Reviewed-by: Anton Johansson <anjo@rev.ng>
> Message-Id: <20231212123401.37493-16-philmd@linaro.org>
> ---
>   include/exec/tswap.h     | 12 +++++++++++-
>   include/hw/core/cpu.h    | 11 -----------
>   cpu-target.c             |  1 +
>   disas/disas.c            |  1 +
>   hw/audio/virtio-snd.c    |  2 +-
>   hw/core/cpu-sysemu.c     |  2 +-
>   hw/core/generic-loader.c |  2 +-
>   hw/display/vga.c         |  2 +-
>   hw/virtio/virtio.c       |  1 +
>   9 files changed, 18 insertions(+), 16 deletions(-)

As an intermediate step, this is ok, I guess, so

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

But most of these files that include this header should be using a CPUClass hook, or a 
device property, or something else.


r~