[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v10 1/6] ui/gtk: Check if fence_fd is equal to or greater tha
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH v10 1/6] ui/gtk: Check if fence_fd is equal to or greater than 0 |
|
Date: |
Tue, 23 Apr 2024 14:54:00 +0100 |
|
User-agent: |
Mutt/2.2.12 (2023-09-09) |
On Mon, Apr 22, 2024 at 07:22:48PM -0700, dongwon.kim@intel.com wrote:
> From: Dongwon Kim <dongwon.kim@intel.com>
>
> 'fence_fd' needs to be validated always before being referenced
> And the passing condition should include '== 0' as 0 is a valid
> value for the file descriptor.
>
> Suggested-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Cc: Philippe Mathieu-Daudé <philmd@linaro.org>
> Cc: Daniel P. Berrangé <berrange@redhat.com>
> Cc: Vivek Kasireddy <vivek.kasireddy@intel.com>
> Signed-off-by: Dongwon Kim <dongwon.kim@intel.com>
> ---
> ui/gtk-egl.c | 2 +-
> ui/gtk-gl-area.c | 2 +-
> ui/gtk.c | 10 ++++++----
> 3 files changed, 8 insertions(+), 6 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|