[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/6] migration: Remove 'blk/-b' option from migrate commands
|
From: |
Fabiano Rosas |
|
Subject: |
Re: [PATCH 3/6] migration: Remove 'blk/-b' option from migrate commands |
|
Date: |
Fri, 26 Apr 2024 11:19:31 -0300 |
Markus Armbruster <armbru@redhat.com> writes:
> Markus Armbruster <armbru@redhat.com> writes:
>
>> Fabiano Rosas <farosas@suse.de> writes:
>>
>>> The block migration is considered obsolete and has been deprecated in
>>> 8.2. Remove the migrate command option that enables it. This only
>>> affects the QMP and HMP commands, the feature can still be accessed by
>>> setting the migration 'block' capability. The whole feature will be
>>> removed in a future patch.
>>>
>>> Deprecation commit 8846b5bfca ("migration: migrate 'blk' command
>>> option is deprecated.").
>>>
>>> Signed-off-by: Fabiano Rosas <farosas@suse.de>
>>
>> Reviewed-by: Markus Armbruster <armbru@redhat.com>
>
> I think you missed the update to hmp-commands.hx. I almost missed it,
> too :)
Nice catch, it was bound to happen. There's approximately 9000 instances
of 'blk' in this project.
- [PATCH 0/6] migration removals & deprecations, Fabiano Rosas, 2024/04/25
- [PATCH 4/6] migration: Remove block migration, Fabiano Rosas, 2024/04/25
- [PATCH 6/6] migration: Deprecate fd: for file migration, Fabiano Rosas, 2024/04/25
- [PATCH 5/6] migration: Remove non-multifd compression, Fabiano Rosas, 2024/04/25
- Re: [PATCH 0/6] migration removals & deprecations, Markus Armbruster, 2024/04/26