Re: [PATCH v8 07/11] virtio-gpu: Support suspension of commands processing

[Akihiko Odaki]

On 2024/04/24 18:43, Dmitry Osipenko wrote:
> On 4/19/24 11:53, Akihiko Odaki wrote:
> > On 2024/04/19 4:00, Dmitry Osipenko wrote:
> > > Add new "suspended" flag to virtio_gpu_ctrl_command telling cmd
> > > processor that it should stop processing commands and retry again
> > > next time until flag is unset.
> > >
> > > Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> >
> > This flag shouldn't be added to virtio_gpu_ctrl_command. suspended is
> > just !finished in virtio-gpu.c. Only virtio_gpu_virgl_process_cmd()
> > needs the distinction of suspended and !finished so it is not
> > appropriate to add this flag the common structure.
>
> The VIRTIO_GPU_FILL_CMD() macro returns void and this macro is used by
> every function processing commands. Changing process_cmd() to return
> bool will require to change all those functions. Not worthwhile to
> change it, IMO. >
> The flag reflects the exact command status. The !finished + !suspended
> means that command is fenced, i.e. these flags don't have exactly same
> meaning.

It is not necessary to change the signature of process_cmd(). You can 
just refer to !finished. No need to have the suspended flag.

> I'd keep the flag if there are no better suggestions.