Re: [PATCH v8 08/11] virtio-gpu: Handle resource blob commands

[Akihiko Odaki]

On 2024/04/24 19:30, Dmitry Osipenko wrote:
> On 4/19/24 12:18, Akihiko Odaki wrote:
> > > @@ -61,6 +61,10 @@ struct virtio_gpu_simple_resource {
> > >        int dmabuf_fd;
> > >        uint8_t *remapped;
> > >    +    MemoryRegion *mr;
> > > +    bool async_unmap_completed;
> > > +    bool async_unmap_in_progress;
> > > +
> >
> > Don't add fields to virtio_gpu_simple_resource but instead create a
> > struct that embeds virtio_gpu_simple_resource in virtio-gpu-virgl.c.
>
> Please give a justification. I'd rather rename
> virtio_gpu_simple_resource s/_simple//. Simple resource already supports
> blob and the added fields are directly related to the blob. Don't see
> why another struct is needed.

Because mapping is only implemented in virtio-gpu-gl while blob itself 
is implemented also in virtio-gpu.