Re: [PATCH v2] migration/colo: Fix bdrv_graph_rdlock_main_loop: Assertion `!qemu_in_coroutine()' failed.

[Michael Tokarev]

17.04.2024 05:56, Li Zhijian via wrote:
> --- a/migration/colo.c
> +++ b/migration/colo.c
> @@ -835,6 +835,16 @@ static void *colo_process_incoming_thread(void *opaque)
>           return NULL;
>       }
>   
> +    /* Make sure all file formats throw away their mutable metadata */
> +    bql_lock();
> +    bdrv_activate_all(&local_err);
> +    if (local_err) {
> +        bql_unlock();
> +        error_report_err(local_err);
> +        return NULL;
> +    }
> +    bql_unlock();
FWIW, this can be simplified as follows:

   bql_lock();
   bdrv_activate_all(&local_err);
   bql_unlock();
   if (local_err) {
        error_report_err(local_err);
        return NULL;
   }

(I know it is already too late)

/mjt

--
GPG Key transition (from rsa2048 to rsa4096) since 2024-04-24.
New key: rsa4096/61AD3D98ECDF2C8E  9D8B E14E 3F2A 9DD7 9199  28F1 61AD 3D98 
ECDF 2C8E
Old key: rsa2048/457CE0A0804465C5  6EE1 95D1 886E 8FFB 810D  4324 457C E0A0 
8044 65C5
Transition statement: http://www.corpit.ru/mjt/gpg-transition-2024.txt