Re: [PATCH v2 09/33] plugins: Copy memory in qemu_plugin_insn_data

[Philippe Mathieu-Daudé]

On 25/4/24 01:31, Richard Henderson wrote:
> Instead of returning a host pointer, copy the data into
> storage provided by the caller.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   include/qemu/qemu-plugin.h | 15 +++++++--------
>   contrib/plugins/execlog.c  |  5 +++--
>   contrib/plugins/howvec.c   |  4 ++--
>   plugins/api.c              |  7 +++++--
>   4 files changed, 17 insertions(+), 14 deletions(-)

>   /**
>    * struct qemu_info_t - system information for plugins
> @@ -394,17 +394,16 @@ struct qemu_plugin_insn *
>   qemu_plugin_tb_get_insn(const struct qemu_plugin_tb *tb, size_t idx);
>   
>   /**
> - * qemu_plugin_insn_data() - return ptr to instruction data
> + * qemu_plugin_insn_data() - copy instruction data

"copy of "?

>    * @insn: opaque instruction handle from qemu_plugin_tb_get_insn()
> + * @dest: destination into which data is copied
> + * @len: length of dest

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>