Re: [PATCH v2 11/33] plugins: Use translator_st for qemu_plugin_insn_data

[Philippe Mathieu-Daudé]

On 25/4/24 01:31, Richard Henderson wrote:
> Use the bytes that we record for the entire TB, rather than
> a per-insn GByteArray.  Record the length of the insn in
> plugin_gen_insn_end rather than infering from the length
> of the array.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   include/qemu/plugin.h  | 14 +-------------
>   accel/tcg/plugin-gen.c |  7 +++++--
>   accel/tcg/translator.c | 26 --------------------------
>   plugins/api.c          | 12 +++++++-----
>   tcg/tcg.c              |  3 +--
>   5 files changed, 14 insertions(+), 48 deletions(-)

Nice!

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>