qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 02/19] vfio/container: Introduce HostIOMMUDeviceLegacyVFIO


From: Cédric Le Goater
Subject: Re: [PATCH v3 02/19] vfio/container: Introduce HostIOMMUDeviceLegacyVFIO device
Date: Tue, 30 Apr 2024 14:00:30 +0200
User-agent: Mozilla Thunderbird

On 4/30/24 11:13, Duan, Zhenzhong wrote:


-----Original Message-----
From: Cédric Le Goater <clg@redhat.com>
Subject: Re: [PATCH v3 02/19] vfio/container: Introduce
HostIOMMUDeviceLegacyVFIO device

On 4/29/24 08:50, Zhenzhong Duan wrote:
HostIOMMUDeviceLegacyVFIO represents a host IOMMU device under
VFIO
legacy container backend.

It includes a link to VFIODevice.

I don't see any use of this attribute. May be introduce later when needed.

Indeed, will remove.

Then 'struct HostIOMMUDeviceLegacyVFIO' is same as
struct HostIOMMUDevice.

Not clear if it's preferred to remove 'struct HostIOMMUDeviceLegacyVFIO'
and use HostIOMMUDevice instead. Something like:

OBJECT_DECLARE_SIMPLE_TYPE(HostIOMMUDevice,
                                             HOST_IOMMU_DEVICE_LEGACY_VFIO)

I would. The simpler the better.

Thanks,

C.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]