[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 5/5] qapi: introduce exit-on-error parameter for migrate-i
|
From: |
Fabiano Rosas |
|
Subject: |
Re: [PATCH v6 5/5] qapi: introduce exit-on-error parameter for migrate-incoming |
|
Date: |
Tue, 30 Apr 2024 11:40:08 -0300 |
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> writes:
> Now we do set MIGRATION_FAILED state, but don't give a chance to
> orchestrator to query migration state and get the error.
>
> Let's provide a possibility for QMP-based orchestrators to get an error
> like with outgoing migration.
>
> For hmp_migrate_incoming(), let's enable the new behavior: HMP is not
> and ABI, it's mostly intended to use by developer and it makes sense
> not to stop the process.
>
> For x-exit-preconfig, let's keep the old behavior:
> - it's called from init(), so here we want to keep current behavior by
> default
> - it does exit on error by itself as well
> So, if we want to change the behavior of x-exit-preconfig, it should be
> another patch.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> Acked-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Fabiano Rosas <farosas@suse.de>
- [PATCH v6 0/5] migration: do not exit on incoming failure, Vladimir Sementsov-Ogievskiy, 2024/04/30
- [PATCH v6 3/5] migration: process_incoming_migration_co(): fix reporting s->error, Vladimir Sementsov-Ogievskiy, 2024/04/30
- [PATCH v6 5/5] qapi: introduce exit-on-error parameter for migrate-incoming, Vladimir Sementsov-Ogievskiy, 2024/04/30
- Re: [PATCH v6 5/5] qapi: introduce exit-on-error parameter for migrate-incoming,
Fabiano Rosas <=
- [PATCH v6 4/5] migration: process_incoming_migration_co(): rework error reporting, Vladimir Sementsov-Ogievskiy, 2024/04/30
- [PATCH v6 2/5] migration: process_incoming_migration_co(): complete cleanup on failure, Vladimir Sementsov-Ogievskiy, 2024/04/30
- [PATCH v6 1/5] migration: move trace-point from migrate_fd_error to migrate_set_error, Vladimir Sementsov-Ogievskiy, 2024/04/30