Re: [PATCH v2 5/6] hw/i386/x86: Extract x86_isa_bios_init() from x86_bios_rom_init()

[Philippe Mathieu-Daudé]

On 30/4/24 17:06, Bernhard Beschow wrote:
> The function is inspired by pc_isa_bios_init() and should eventually replace it.
> Using x86_isa_bios_init() rather than pc_isa_bios_init() fixes pflash commands
> to work in the isa-bios region.
>
> While at it convert the magic number 0x100000 (== 1MiB) to increase readability.
>
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> ---
>   include/hw/i386/x86.h |  2 ++
>   hw/i386/x86.c         | 25 ++++++++++++++++---------
>   2 files changed, 18 insertions(+), 9 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>