[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 04/23] Revert "host/i386: assume presence of SSE2"
From: |
Paolo Bonzini |
Subject: |
[PULL 04/23] Revert "host/i386: assume presence of SSE2" |
Date: |
Fri, 28 Jun 2024 19:28:36 +0200 |
This reverts commit b18236897ca15c3db1506d8edb9a191dfe51429c.
The x86-64 instruction set can now be tuned down to x86-64 v1
or i386 Pentium Pro.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
host/include/i386/host/cpuinfo.h | 1 +
util/cpuinfo-i386.c | 1 +
host/include/i386/host/bufferiszero.c.inc | 5 +++--
3 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/host/include/i386/host/cpuinfo.h b/host/include/i386/host/cpuinfo.h
index 72f6fad61e5..81771733eaa 100644
--- a/host/include/i386/host/cpuinfo.h
+++ b/host/include/i386/host/cpuinfo.h
@@ -14,6 +14,7 @@
#define CPUINFO_POPCNT (1u << 4)
#define CPUINFO_BMI1 (1u << 5)
#define CPUINFO_BMI2 (1u << 6)
+#define CPUINFO_SSE2 (1u << 7)
#define CPUINFO_AVX1 (1u << 9)
#define CPUINFO_AVX2 (1u << 10)
#define CPUINFO_AVX512F (1u << 11)
diff --git a/util/cpuinfo-i386.c b/util/cpuinfo-i386.c
index ca74ef04f54..90f92a42dc8 100644
--- a/util/cpuinfo-i386.c
+++ b/util/cpuinfo-i386.c
@@ -34,6 +34,7 @@ unsigned __attribute__((constructor)) cpuinfo_init(void)
if (max >= 1) {
__cpuid(1, a, b, c, d);
+ info |= (d & bit_SSE2 ? CPUINFO_SSE2 : 0);
info |= (c & bit_MOVBE ? CPUINFO_MOVBE : 0);
info |= (c & bit_POPCNT ? CPUINFO_POPCNT : 0);
info |= (c & bit_PCLMUL ? CPUINFO_PCLMUL : 0);
diff --git a/host/include/i386/host/bufferiszero.c.inc
b/host/include/i386/host/bufferiszero.c.inc
index 3b9605d806f..74ae98580f6 100644
--- a/host/include/i386/host/bufferiszero.c.inc
+++ b/host/include/i386/host/bufferiszero.c.inc
@@ -110,13 +110,14 @@ static biz_accel_fn const accel_table[] = {
static unsigned best_accel(void)
{
-#ifdef CONFIG_AVX2_OPT
unsigned info = cpuinfo_init();
+
+#ifdef CONFIG_AVX2_OPT
if (info & CPUINFO_AVX2) {
return 2;
}
#endif
- return 1;
+ return info & CPUINFO_SSE2 ? 1 : 0;
}
#else
--
2.45.2
- [PULL v3 00/23] Misc changes for 2024-06-28, Paolo Bonzini, 2024/06/28
- [PULL 01/23] configure: detect --cpu=mipsisa64r6, Paolo Bonzini, 2024/06/28
- [PULL 03/23] Revert "host/i386: assume presence of SSSE3", Paolo Bonzini, 2024/06/28
- [PULL 05/23] meson: allow configuring the x86-64 baseline, Paolo Bonzini, 2024/06/28
- [PULL 02/23] Revert "host/i386: assume presence of POPCNT", Paolo Bonzini, 2024/06/28
- [PULL 04/23] Revert "host/i386: assume presence of SSE2",
Paolo Bonzini <=
- [PULL 07/23] block: make assertion more generic, Paolo Bonzini, 2024/06/28
- [PULL 06/23] meson: remove dead optimization option, Paolo Bonzini, 2024/06/28
- [PULL 08/23] block: do not check bdrv_file_open, Paolo Bonzini, 2024/06/28
- [PULL 09/23] block: remove separate bdrv_file_open callback, Paolo Bonzini, 2024/06/28
- [PULL 10/23] block: rename former bdrv_file_open callbacks, Paolo Bonzini, 2024/06/28
- [PULL 11/23] exec: avoid using C++ keywords in function parameters, Paolo Bonzini, 2024/06/28
- [PULL 13/23] include: move typeof_strip_qual to compiler.h, use it in QAPI_LIST_LENGTH(), Paolo Bonzini, 2024/06/28
- [PULL 14/23] target/i386: fix CC_OP dump, Paolo Bonzini, 2024/06/28
- [PULL 15/23] target/i386: use cpu_cc_dst for CC_OP_POPCNT, Paolo Bonzini, 2024/06/28
- [PULL 12/23] exec: don't use void* in pointer arithmetic in headers, Paolo Bonzini, 2024/06/28