Re: [PATCH] hw/ppc: Implement -dtb support for PowerNV

[Cédric Le Goater]

On 8/1/24 09:44, Cédric Le Goater wrote:
> > -    /* Pack resulting tree */
> > -    _FDT((fdt_pack(fdt)));
> > +        /* read the file 'machine->dtb', and load it into 'fdt' buffer */
> > +        if (!g_file_get_contents(machine->dtb, (gchar **)&fdt, NULL, NULL)) {
> > +            error_report("Could not load dtb '%s'", machine->dtb);
> > +            exit(1);
> > +        }
>
> We should try to report such errors earlier than in reset.
>
> Can you please introduce a PnvMachineState::dtb attribute and initialize it
> in pnv_init() after ->initrd_filename.

PnvMachineState::fdt might be a more appropriate name.

Thanks,

C.