Re: [PATCH v2 0/4] hw/pci: Convert rom_bar into OnOffAuto

[Akihiko Odaki]

On 2024/08/01 16:52, Michael S. Tsirkin wrote:
> On Thu, Aug 01, 2024 at 04:01:44PM +0900, Akihiko Odaki wrote:
> > rom_bar_set() and and underlying visit_type_str_preserving() are ugly, but
> > we can remove them once the deprecation period ends. On the other hand, if
> > we don't make this change, dev->opts will keep floating around, and we will
> > even have another use of it for "[PATCH v5 1/8] hw/pci: Do not add ROM BAR
> > for SR-IOV VF"[1]. Eventually, having this refactoring early will result in
> > less mess in the future.
> >
> > [1]: lore.kernel.org/r/20240715-sriov-v5-1-3f5539093ffc@daynix.com
>
> I don't know that this should worry us much. Is there some project that
> requires getting rid of dev->opts for some reason?

No, but I just thought it is too ugly to add a new reference to it for 
the aforementioned patch, circumventing the visitor code and the QOM 
property.

Regards,
Akihiko Odaki