Re: [PULL 02/22] tests/avocado: use snapshot=on in kvm_xen_guest

[David Woodhouse]

On Fri, 2024-01-12 at 11:04 +0000, Alex Bennée wrote:
> This ensures the rootfs is never permanently changed as we don't need
> persistence between tests anyway.
> 
> Message-Id: <20240103173349.398526-3-alex.bennee@linaro.org>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> 
> diff --git a/tests/avocado/kvm_xen_guest.py b/tests/avocado/kvm_xen_guest.py
> index 5391283113e..f8cb458d5db 100644
> --- a/tests/avocado/kvm_xen_guest.py
> +++ b/tests/avocado/kvm_xen_guest.py
> @@ -59,7 +59,7 @@ def common_vm_setup(self):
>      def run_and_check(self):
>          self.vm.add_args('-kernel', self.kernel_path,
>                           '-append', self.kernel_params,
> -                         '-drive',  
> f"file={self.rootfs},if=none,format=raw,id=drv0",
> +                         '-drive',  
> f"file={self.rootfs},if=none,snapshot=on,format=raw,id=drv0",
>                           '-device', 'xen-disk,drive=drv0,vdev=xvda',
>                           '-device', 'virtio-net-pci,netdev=unet',
>                           '-netdev', 'user,id=unet,hostfwd=:127.0.0.1:0-:22')

I don't even understand why it needs to be writable at all. Could we just fix 
that?

smime.p7s
Description: S/MIME cryptographic signature