Re: [PATCH 10/13] tests/avocado/tuxrun_baselines.py: use Avocado's zstd support

[Philippe Mathieu-Daudé]

On 1/8/24 05:39, Cleber Rosa wrote:
> On Mon, Jul 29, 2024 at 10:39 AM Philippe Mathieu-Daudé
> <philmd@linaro.org> wrote:
> > On 26/7/24 15:44, Cleber Rosa wrote:
> > > Signed-off-by: Cleber Rosa <crosa@redhat.com>
> > > ---
> > >    tests/avocado/tuxrun_baselines.py | 16 ++++++----------
> > >    1 file changed, 6 insertions(+), 10 deletions(-)
> > >
> > > diff --git a/tests/avocado/tuxrun_baselines.py 
> > > b/tests/avocado/tuxrun_baselines.py
> > > index 736e4aa289..bd02e88ed6 100644
> > > --- a/tests/avocado/tuxrun_baselines.py
> > > +++ b/tests/avocado/tuxrun_baselines.py
> > > @@ -17,6 +17,7 @@
> > >    from avocado_qemu import QemuSystemTest
> > >    from avocado_qemu import exec_command, exec_command_and_wait_for_pattern
> > >    from avocado_qemu import wait_for_console_pattern
> > > +from avocado.utils import archive
> > >    from avocado.utils import process
> > >    from avocado.utils.path import find_command
> > >
> > > @@ -40,17 +41,12 @@ def get_tag(self, tagname, default=None):
> > >
> > >            return default
> > >
> > > +    @skipUnless(archive._probe_zstd_cmd(),
> >
> > _probe_zstd_cmd() isn't public AFAICT, but more importantly
> > this doesn't work because this method has been added in v101.0.
>
> While it's not the best practice to use private functions, I just
> couldn't accept rewriting that for the skip condition.  I can make
> sure future  versions (including 103.1) make it public.
>
> Also, these patches count on the bump to 103.0 indeed.

Then either mention it in the commit description to avoid wasting
time to developers cherry-picking / testing this single patch, or
move it after the version bump, avoiding bisectability issues.

Thanks,

Phil.