[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 2/4] accel/kvm/kvm-all: Fixes the missing break in vCPU unpark log
|
From: |
Peter Maydell |
|
Subject: |
[PULL 2/4] accel/kvm/kvm-all: Fixes the missing break in vCPU unpark logic |
|
Date: |
Thu, 1 Aug 2024 15:23:20 +0100 |
From: Salil Mehta <salil.mehta@huawei.com>
Loop should exit prematurely on successfully finding out the parked vCPU (struct
KVMParkedVcpu) in the 'struct KVMState' maintained 'kvm_parked_vcpus' list of
parked vCPUs.
Fixes: Coverity CID 1558552
Fixes: 08c3286822 ("accel/kvm: Extract common KVM vCPU {creation,parking} code")
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Gavin Shan <gshan@redhat.com>
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Message-id: 20240725145132.99355-1-salil.mehta@huawei.com
Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Message-ID: <CAFEAcA-3_d1c7XSXWkFubD-LsW5c5i95e6xxV09r2C9yGtzcdA@mail.gmail.com>
Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
accel/kvm/kvm-all.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
index e1d13863063..75d11a07b2b 100644
--- a/accel/kvm/kvm-all.c
+++ b/accel/kvm/kvm-all.c
@@ -362,6 +362,7 @@ int kvm_unpark_vcpu(KVMState *s, unsigned long vcpu_id)
QLIST_REMOVE(cpu, node);
kvm_fd = cpu->kvm_fd;
g_free(cpu);
+ break;
}
}
--
2.34.1
- [PULL 0/4] target-arm queue, Peter Maydell, 2024/08/01
- [PULL 0/4] target-arm queue, Peter Maydell, 2024/08/13
- [PULL 1/4] hw/misc/stm32l4x5_rcc: Add validation for MCOPRE and MCOSEL values, Peter Maydell, 2024/08/13
- [PULL 2/4] target/arm: Clear high SVE elements in handle_vec_simd_wshli, Peter Maydell, 2024/08/13
- [PULL 3/4] target/arm: Update translation regime comment for new features, Peter Maydell, 2024/08/13
- [PULL 4/4] target/arm: Fix usage of MMU indexes when EL3 is AArch32, Peter Maydell, 2024/08/13
- Re: [PULL 0/4] target-arm queue, Richard Henderson, 2024/08/13