[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 3/6] qapi: use "QAPI_FEATURE" as namespace for features
|
From: |
Daniel P . Berrangé |
|
Subject: |
[PATCH 3/6] qapi: use "QAPI_FEATURE" as namespace for features |
|
Date: |
Thu, 1 Aug 2024 18:59:10 +0100 |
This more clearly distinguishes the feature constants from other
QAPI constants.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
include/qapi/util.h | 4 ++--
qapi/qapi-util.c | 4 ++--
qapi/qobject-output-visitor.c | 4 ++--
scripts/qapi/gen.py | 2 +-
4 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/include/qapi/util.h b/include/qapi/util.h
index b377cb9c70..a693cac9ea 100644
--- a/include/qapi/util.h
+++ b/include/qapi/util.h
@@ -12,8 +12,8 @@
#define QAPI_UTIL_H
typedef enum {
- QAPI_DEPRECATED,
- QAPI_UNSTABLE,
+ QAPI_FEATURE_DEPRECATED,
+ QAPI_FEATURE_UNSTABLE,
} QapiFeature;
typedef struct QEnumLookup {
diff --git a/qapi/qapi-util.c b/qapi/qapi-util.c
index 3d849fe034..48c8c867d3 100644
--- a/qapi/qapi-util.c
+++ b/qapi/qapi-util.c
@@ -43,13 +43,13 @@ bool compat_policy_input_ok(uint64_t features,
const char *kind, const char *name,
Error **errp)
{
- if ((features & 1u << QAPI_DEPRECATED)
+ if ((features & 1u << QAPI_FEATURE_DEPRECATED)
&& !compat_policy_input_ok1("Deprecated",
policy->deprecated_input,
error_class, kind, name, errp)) {
return false;
}
- if ((features & (1u << QAPI_UNSTABLE))
+ if ((features & (1u << QAPI_FEATURE_UNSTABLE))
&& !compat_policy_input_ok1("Unstable",
policy->unstable_input,
error_class, kind, name, errp)) {
diff --git a/qapi/qobject-output-visitor.c b/qapi/qobject-output-visitor.c
index 8902287caa..b13c94d913 100644
--- a/qapi/qobject-output-visitor.c
+++ b/qapi/qobject-output-visitor.c
@@ -214,9 +214,9 @@ static bool qobject_output_policy_skip(Visitor *v, const
char *name,
{
CompatPolicy *pol = &v->compat_policy;
- return ((features & 1u << QAPI_DEPRECATED)
+ return ((features & 1u << QAPI_FEATURE_DEPRECATED)
&& pol->deprecated_output == COMPAT_POLICY_OUTPUT_HIDE)
- || ((features & 1u << QAPI_UNSTABLE)
+ || ((features & 1u << QAPI_FEATURE_UNSTABLE)
&& pol->unstable_output == COMPAT_POLICY_OUTPUT_HIDE);
}
diff --git a/scripts/qapi/gen.py b/scripts/qapi/gen.py
index e6c80cce23..0ff29dc776 100644
--- a/scripts/qapi/gen.py
+++ b/scripts/qapi/gen.py
@@ -41,7 +41,7 @@
def gen_features(features: Sequence[QAPISchemaFeature]) -> str:
- features = [f"1u << QAPI_{feat.name.upper()}"
+ features = [f"1u << QAPI_FEATURE_{feat.name.upper()}"
for feat in features if feat.is_special()]
return ' | '.join(features) or '0'
--
2.45.2
- [PATCH 0/6] qapi: generalize special features, Daniel P . Berrangé, 2024/08/01
- [PATCH 1/6] qapi: change 'unsigned special_features' to 'uint64_t features', Daniel P . Berrangé, 2024/08/01
- [PATCH 2/6] scripts/qapi: rename 'special_features' to 'features', Daniel P . Berrangé, 2024/08/01
- [PATCH 3/6] qapi: use "QAPI_FEATURE" as namespace for features,
Daniel P . Berrangé <=
- [PATCH 4/6] qapi: cope with feature names containing a '-', Daniel P . Berrangé, 2024/08/01
- [PATCH 5/6] qapi: apply schema prefix to QAPI feature enum constants, Daniel P . Berrangé, 2024/08/01
- Re: [PATCH 5/6] qapi: apply schema prefix to QAPI feature enum constants, Markus Armbruster, 2024/08/05
- Re: [PATCH 5/6] qapi: apply schema prefix to QAPI feature enum constants, Daniel P . Berrangé, 2024/08/05
- Re: [PATCH 5/6] qapi: apply schema prefix to QAPI feature enum constants, Markus Armbruster, 2024/08/05
- Re: [PATCH 5/6] qapi: apply schema prefix to QAPI feature enum constants, Daniel P . Berrangé, 2024/08/05
- Re: [PATCH 5/6] qapi: apply schema prefix to QAPI feature enum constants, Markus Armbruster, 2024/08/05
- Re: [PATCH 5/6] qapi: apply schema prefix to QAPI feature enum constants, Markus Armbruster, 2024/08/05