[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] migration: Fix cleanup of iochannel in file migration
|
From: |
Peter Xu |
|
Subject: |
Re: [PATCH 1/2] migration: Fix cleanup of iochannel in file migration |
|
Date: |
Thu, 1 Aug 2024 14:39:05 -0400 |
On Thu, Aug 01, 2024 at 02:41:00PM -0300, Fabiano Rosas wrote:
> The QIOChannelFile object already has its reference decremented by
> g_autoptr. Trying to unref an extra time causes:
>
> ERROR:../qom/object.c:1241:object_unref: assertion failed: (obj->ref > 0)
>
> Fixes: a701c03dec ("migration: Drop reference to QIOChannel if file seeking
> fails")
> Fixes: 6d3279655a ("migration: Fix file migration with fdset")
> Reported-by: Jim Fehlig <jfehlig@suse.com>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
Ouch..
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu