[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH for-9.2 v6 2/9] hw/pci: Fix SR-IOV VF number calculation
|
From: |
Akihiko Odaki |
|
Subject: |
[PATCH for-9.2 v6 2/9] hw/pci: Fix SR-IOV VF number calculation |
|
Date: |
Fri, 02 Aug 2024 15:49:46 +0900 |
pci_config_get_bar_addr() had a division by vf_stride. vf_stride needs
to be non-zero when there are multiple VFs, but the specification does
not prohibit to make it zero when there is only one VF.
Do not perform the division for the first VF to avoid division by zero.
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
hw/pci/pci.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index 60b1747d60e6..0956fe5eb444 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -1437,7 +1437,11 @@ static pcibus_t pci_config_get_bar_addr(PCIDevice *d,
int reg,
pci_get_word(pf->config + sriov_cap + PCI_SRIOV_VF_OFFSET);
uint16_t vf_stride =
pci_get_word(pf->config + sriov_cap + PCI_SRIOV_VF_STRIDE);
- uint32_t vf_num = (d->devfn - (pf->devfn + vf_offset)) / vf_stride;
+ uint32_t vf_num = d->devfn - (pf->devfn + vf_offset);
+
+ if (vf_num) {
+ vf_num /= vf_stride;
+ }
if (type & PCI_BASE_ADDRESS_MEM_TYPE_64) {
new_addr = pci_get_quad(pf->config + bar);
--
2.45.2
- [PATCH for-9.2 v6 0/9] virtio-net: add support for SR-IOV emulation, Akihiko Odaki, 2024/08/02
- [PATCH for-9.2 v6 1/9] hw/pci: Do not add ROM BAR for SR-IOV VF, Akihiko Odaki, 2024/08/02
- [PATCH for-9.2 v6 2/9] hw/pci: Fix SR-IOV VF number calculation,
Akihiko Odaki <=
- [PATCH for-9.2 v6 3/9] pcie_sriov: Ensure PF and VF are mutually exclusive, Akihiko Odaki, 2024/08/02
- [PATCH for-9.2 v6 4/9] pcie_sriov: Check PCI Express for SR-IOV PF, Akihiko Odaki, 2024/08/02
- [PATCH for-9.2 v6 5/9] pcie_sriov: Allow user to create SR-IOV device, Akihiko Odaki, 2024/08/02
- [PATCH for-9.2 v6 6/9] virtio-pci: Implement SR-IOV PF, Akihiko Odaki, 2024/08/02
- [PATCH for-9.2 v6 7/9] virtio-net: Implement SR-IOV VF, Akihiko Odaki, 2024/08/02
- [PATCH for-9.2 v6 8/9] docs: Document composable SR-IOV device, Akihiko Odaki, 2024/08/02
- [PATCH for-9.2 v6 9/9] pcie_sriov: Make a PCI device with user-created VF ARI-capable, Akihiko Odaki, 2024/08/02