Re: [PULL 05/21] hvf: arm: Raise an exception for sysreg by default

[Richard Henderson]

On 7/30/24 19:40, Peter Maydell wrote:
> From: Akihiko Odaki <akihiko.odaki@daynix.com>
>
> Any sysreg access results in an exception unless defined otherwise so
> we should raise an exception by default.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>   target/arm/hvf/hvf.c | 174 +++++++++++++++++++++----------------------
>   1 file changed, 85 insertions(+), 89 deletions(-)


This patch fails to compile:

https://gitlab.com/qemu-project/qemu/-/jobs/7489527235

../target/arm/hvf/hvf.c:1283:42: error: incompatible pointer types passing 'uint64_t **' 
(aka 'unsigned long long **') to parameter of type 'uint64_t *' (aka 'unsigned long long 
*'); remove & [-Werror,-Wincompatible-pointer-types]
        if (hvf_sysreg_read_cp(cpu, reg, &val)) {
                                         ^~~~
../target/arm/hvf/hvf.c:1175:71: note: passing argument to parameter 'val' here
static bool hvf_sysreg_read_cp(CPUState *cpu, uint32_t reg, uint64_t *val)
                                                                      ^
1 error generated.

This snuck in while our Cirrus build minutes were exhausted, but it suggests that the 
patch was never tested at all.


r~