[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 0/2] qdev-monitor: avoid QemuOpts in QMP device_add
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH v2 0/2] qdev-monitor: avoid QemuOpts in QMP device_add |
|
Date: |
Fri, 02 Aug 2024 10:10:43 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Can we additionally cut out the QemuOpts middleman in
usbback_portid_add()?
qdict = qdict_new();
qdict_put_str(qdict, "driver", "usb-host");
tmp = g_strdup_printf("%s.0", usbif->xendev.qdev.id);
qdict_put_str(qdict, "bus", tmp);
g_free(tmp);
tmp = g_strdup_printf("%s-%u", usbif->xendev.qdev.id, port);
qdict_put_str(qdict, "id", tmp);
g_free(tmp);
qdict_put_int(qdict, "port", port);
qdict_put_int(qdict, "hostbus", atoi(busid));
qdict_put_str(qdict, "hostport", portname);
opts = qemu_opts_from_qdict(qemu_find_opts("device"), qdict,
&error_abort);
usbif->ports[port - 1].dev = USB_DEVICE(qdev_device_add(opts, &local_err));
Trying this is up to you!